improve editor parsing

saw-leipzig · Mar 10, 2023 · a935a35 · a935a35
1 parent aa1b32d
commit a935a35
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/csv2cmi.ini b/csv2cmi.ini
@@ -1,6 +1,6 @@
 [Project]
 title = cmi2csv example
-editor = Klaus Rettinghaus
+editor = Erika Musterfrau <musterfrau@saw-leipzig.de>
 publisher = Sächsische Akademie der Wissenschaften zu Leipzig
 fileURL = https://raw.githubusercontent.com/saw-leipzig/csv2cmi/master/example/Example.xml
 extra-delimiter = ;

diff --git a/csv2cmi.py b/csv2cmi.py
@@ -135,12 +135,15 @@ def createFileDesc(config):
     editors = ['']
     editors = config.get('Project', 'editor').splitlines()
     for entity in editors:
-        editor = SubElement(titleStmt, 'editor')
-        if "@" in entity:
-            editor.text = parseaddr(entity)[0] + " "
-            SubElement(editor, 'email').text = parseaddr(entity)[-1]
+        mailbox = parseaddr(entity)
+        if "@" in entity and any(mailbox):
+            editor = SubElement(titleStmt, 'editor')
+            if mailbox[0]:
+                editor.text = mailbox[0] + " "
+            if mailbox[-1]:
+                SubElement(editor, 'email').text = mailbox[-1]
         else:
-            editor.text = entity
+            SubElement(titleStmt, 'editor').text = entity
     if len(list(titleStmt)) == 1:
         logging.warning('Editor missing')
         SubElement(titleStmt, 'editor')