Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache condtion and gh test jobs #50

Merged
merged 2 commits into from
Dec 27, 2020
Merged

Add cache condtion and gh test jobs #50

merged 2 commits into from
Dec 27, 2020

Conversation

say8425
Copy link
Owner

@say8425 say8425 commented Dec 27, 2020

Story

  • Testing a released gh action is too difficult.
  • Jobs are too big.
  • Installing dependencies are always running.

Solves

In Addition

The workflow is not valid. .github/workflows/test.yml (Line: 89, Col: 15): Unrecognized named-value: 'github'. Located at position 1 within expression: github.action_path
https://github.com/say8425/aws-secrets-manager-actions/actions/runs/446727841

  • uses: ${{ github.action_path }} looks best, but uses looks not allow contexts.

References

@say8425 say8425 added the 🏭 ci Faster and more reliable label Dec 27, 2020
@say8425 say8425 added this to the v1.3 milestone Dec 27, 2020
@say8425 say8425 self-assigned this Dec 27, 2020
@say8425 say8425 force-pushed the refactor/workflow branch 8 times, most recently from af0b221 to 5ed9074 Compare December 27, 2020 15:41
@say8425 say8425 linked an issue Dec 27, 2020 that may be closed by this pull request
@say8425 say8425 merged commit 49b6ef6 into master Dec 27, 2020
@say8425 say8425 deleted the refactor/workflow branch December 27, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏭 ci Faster and more reliable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add test for gh workflow
1 participant