Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Theming Feature #187

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Harish-M-2003
Copy link

@Harish-M-2003 Harish-M-2003 commented Jan 16, 2024

Description

Introduce a toggle button for changing the theme in the application.

Related Issue(s)

Closes #176

Changes Made

  • Implemented a new ThemeToggle component.
  • Integrated the toggle button into the header section.
  • Added event handling to toggle between light and dark themes.
  • Updated the app's styling dynamically based on the selected theme.

Screenshots (if applicable)

[Include screenshots or images that demonstrate the new toggle button and its functionality.]

Checklist

Please review and check the following before submitting your pull request:

  • I have followed the Code of Conduct.
  • My code follows the project's contributing guidelines.
  • I have tested my changes locally, and they work as expected.
  • I have included relevant tests for my changes.
  • I have updated the project documentation if necessary.
  • I have reviewed my code to ensure it is free of debugging or development-related code.
  • I have provided clear and informative commit messages.

Additional Notes (if any)

[Include any additional information, context, or notes that might be relevant to the reviewer or project maintainers.]

Contributor License Agreement

By submitting this pull request, I confirm that my contribution is made under the terms of the project's License, and I agree to abide by the project's Code of Conduct.

Introduce a theming feature to customize the appearance of the application.
@sayakongit sayakongit self-requested a review January 16, 2024 15:02
@sayakongit
Copy link
Owner

Hi @Harish-M-2003 great work! But I found some inconsistencies in the UI. Please fix those and let me know here.

Screenshot 2024-01-16 204701
Screenshot 2024-01-16 204329
Screenshot 2024-01-16 204240
Screenshot 2024-01-16 204220
Screenshot 2024-01-16 204117

@Harish-M-2003
Copy link
Author

Thank you, @sayakongit. I've acknowledged the feedback and will make the necessary corrections. I'll keep you posted on my progress.

@Harish-M-2003
Copy link
Author

@sayakongit I'm working on it and need a week to finalize tasks. Your consideration is highly appreciated.

@sayakongit
Copy link
Owner

Sure @Harish-M-2003 take your time

@sayakongit
Copy link
Owner

@Harish-M-2003 what's the update?

@Harish-M-2003
Copy link
Author

Will push those by tomorrow

@Harish-M-2003
Copy link
Author

I've pushed updates addressing UI inconsistency. Before finalizing these changes, I would greatly appreciate it if you could review them to ensure everything is correct.

Thank you for your patience and understanding.

@Harish-M-2003
Copy link
Author

I have tried extensively to change the language translation component, but I couldn't. Is there any way to do that?

Screenshot 2024-02-11 141747

@sayakongit
Copy link
Owner

I have tried extensively to change the language translation component, but I couldn't. Is there any way to do that?

Screenshot 2024-02-11 141747

You could do one thing. Hide the dropdown with CSS and put a Language icon there as a button to call the dropdown programmatically, Hope that makes sense, Let me know if you have any doubt,

@Harish-M-2003
Copy link
Author

I'll try it and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Dark mode support
2 participants