-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance of a content renderer for the DynamicParagraph #412
Comments
Runs almost fine on my machine. I'll try it on an old machine. |
Ah I see... number of files is the issue. |
Not good... We should pass only the visible nodes in the Lua function. |
Yes, exactly, the number of files is what makes a difference, sorry for not being clear enough, as my laptop is not so old ;) |
🙊 |
Not an easy fix. Need to rethink the API. I don't want to break existing the API, so I'll probably create a new API. But this issue will stay for a while. |
Note: Today I tried to cache |
Finally, found another hack based on caching. Not very pretty, but gets the job done. @igorepst pls test if possible. |
I will, although a bit later. Tnx! |
Seems it works good :) |
The performance of a content renderer for the
DynamicParagraph
(I imagine the same will hold forDynamicList
andDynamicTable
) is pretty bad. Please use the attached minimal config file by runningxplr -c ~/xplr.conf.txt /usr/bin
xplr.conf.txt
(the extension was changed from
lua
totxt
to suit GitHub requirements, but you don't even need to change it back)The file has a
DynamicParagraph
with a renderer that returns some static string. Nevertheless, when I open/usr/bin
with 3756 files and just press and hold 'arrow down', the scroll is super jerky. If, however, you comment theDynamicParagraph
and uncommentStaticParagraph
, the scrolling is smooth as it should be.scroll.mp4
The text was updated successfully, but these errors were encountered: