Fix Lua API performance by caching #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanarijit
force-pushed
the
fix/lua-api-performance
branch
from
0bc2a0f
to
f36f5ec
Compare
Deploying with
|
| Latest commit: |
c505585
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bea6391f.xplr.pages.dev |
sayanarijit
force-pushed
the
fix/lua-api-performance
branch
from
248fcc8
to
8c42466
Compare
sayanarijit
force-pushed
the
fix/lua-api-performance
branch
4 times, most recently
from
0f53802
to
1525748
Compare
|
Seems like there's something wrong with the benchmark tests because I see no way it could impact benchmark. The whole overhead should only apply to plugins.
|
sayanarijit
force-pushed
the
fix/lua-api-performance
branch
3 times, most recently
from
4cf119a
to
5146f36
Compare
sayanarijit
force-pushed
the
fix/lua-api-performance
branch
from
5146f36
to
c505585
Compare
|
Since this is a critical change for being able to use some plugins, I'll be merging this, and create a separate issue for investigating what's with the benchmark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #412