Fix duplicate declaration when the server class is directly used #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajinamit
changed the title
kajinamit
force-pushed
the
server-independent
branch
from
6e80792
to
8fd7e4d
Compare
mbaldessari
reviewed
Mar 29, 2022
... with ssh::match_block, caused by the following references. ssh::server::match_block -> ssh -> ssh::server
kajinamit
force-pushed
the
server-independent
branch
from
8fd7e4d
to
ccfceda
Compare
This change ensures that ssh::params is included before its variable is referenced.
kajinamit
force-pushed
the
server-independent
branch
from
ccfceda
to
11ebe8a
Compare
|
Please have a look at #330 if it's solving your issue |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with ssh::match_block, caused by the following references.
ssh::server::match_block -> ssh -> ssh::server
This also ensures the params class is loaded when picking up its
variable to determine the default value.