fix parameter lookup #330
Closed
fix parameter lookup #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saz
force-pushed
the
fix-client-server-params
branch
10 times, most recently
from
bf35cd2
to
23290f5
Compare
This was referenced Apr 19, 2022
|
@SimonHoenscheid @bastelfreak Would be nice, if you're able to provide some feedback on this PR |
saz
force-pushed
the
fix-client-server-params
branch
5 times, most recently
from
bc2cdcd
to
95fda70
Compare
bastelfreak
reviewed
Apr 20, 2022
saz
force-pushed
the
fix-client-server-params
branch
from
95fda70
to
ab001e0
Compare
|
@saz the client and server class are private, what do I miss here?
|
|
@SimonHoenscheid Sorry, please have a look at #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the merge of #322 it wasn't possible to just manage server
ssh::serveror clientssh::clientwith this module.This PR moves all parameters to the proper location (thanks to #325 this module uses data in modules), which should make things work as before again.
I've also added a few more tests in this PR