conf: Fix the scope of the visudo -c check #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the module does a visudo -c - which check everyfile - to validate that the sudo::conf was correct. Unfortunately, if one needs to be in purge -> false, and some files there have wrong permissions because of a packaging related issues, it cancels the sudo::conf even if the rule is perfectly valid. This patch aims to fix that, using the -f option of visudo to validate only the file we are adding.
Spredzy
force-pushed
the
fix_scoping_visudo_c_check
branch
from
38ad9b9
to
6875e3c
Compare
saz
added a commit
that referenced
this pull request
Mar 5, 2015
conf: Fix the scope of the visudo -c check
beddari
added a commit
to norcams/himlar
that referenced
this pull request
Apr 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the module does a visudo -c - which check everyfile - to
validate that the sudo::conf was correct. Unfortunately, if one needs
to be in purge -> false, and some files there have wrong permissions
because of a packaging related issues, it cancels the sudo::conf even
if the rule is perfectly valid. This patch aims to fix that, using the
-f option of visudo to validate only the file we are adding.