Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-autocomplete): introduce size s #3020

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

Preflight Checklist

Issue

This PR Closes #2768

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • introduce examples for sbb-autocomplete in form-field size=s

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait 'till Monday for the answer to the stories topic

Ps. Do you plan to adapt the autocomplete grid too?

@github-actions github-actions bot temporarily deployed to pr3020 August 23, 2024 16:03 Inactive
@github-actions github-actions bot temporarily deployed to pr3020-diff August 23, 2024 16:03 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one possible improvement

@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Aug 26, 2024
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Aug 26, 2024
@github-actions github-actions bot temporarily deployed to pr3020-diff August 26, 2024 09:14 Inactive
@mcilurzo
Copy link
Contributor

LGTM. Thanks

@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Aug 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit aa55e7f into main Aug 28, 2024
19 of 20 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/sbb-autocomplete-size-s branch August 28, 2024 09:09
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete: Size S
4 participants