Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbb-selection-expansion-panel): introduce size s #3030

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Aug 26, 2024

Preflight Checklist

Issue

This PR Closes #2696

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • the sbb-selection-expansion-panel has now a data-size prop which is set looking at the size change to the inner sbb-radio-button-panel / sbb-checkbox-panel, with a logic that evaluate the origin of the change (from group/from panel with group/from panel without group)

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Aug 26, 2024 that may be closed by this pull request
@github-actions github-actions bot temporarily deployed to pr3030 August 26, 2024 16:34 Inactive
@github-actions github-actions bot temporarily deployed to pr3030-diff August 26, 2024 16:34 Inactive
@DavideMininni-Fincons DavideMininni-Fincons changed the title feat(sbb-selection-expansion-panel): introduce size s [WIP] feat(sbb-selection-expansion-panel): introduce size s Aug 27, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Aug 27, 2024
@github-actions github-actions bot temporarily deployed to pr3030 August 27, 2024 08:45 Inactive
@github-actions github-actions bot temporarily deployed to pr3030-diff August 27, 2024 08:45 Inactive
@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Aug 28, 2024
@mcilurzo
Copy link
Contributor

LGTM. Thanks

@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels Aug 28, 2024
@github-actions github-actions bot added the pr: peer review approved Pull request has been approved by a peer review label Sep 2, 2024
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Sep 5, 2024
@github-actions github-actions bot temporarily deployed to pr3030 September 5, 2024 14:02 Inactive
@github-actions github-actions bot temporarily deployed to pr3030-diff September 5, 2024 14:02 Inactive
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the effort :-)

@DavideMininni-Fincons DavideMininni-Fincons merged commit a04b5b4 into main Sep 5, 2024
19 of 20 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/selection-panel-size-s branch September 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection-Panel: Size S
5 participants