Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix argument ordering for FileField #88

Merged
merged 1 commit into from
Jan 23, 2022
Merged

fix: Fix argument ordering for FileField #88

merged 1 commit into from
Jan 23, 2022

Conversation

last-partizan
Copy link

Argument ordering was incorrect, actually they are in following order:

  • verbose_name
  • name
  • upload_to
  • storage

https://github.com/django/django/blob/2d8232fa716f5fe46eec9f35a0e90c2d0f126279/django/db/models/fields/files.py#L228

sbdchd
sbdchd approved these changes Jan 23, 2022
View reviewed changes
Copy link
Owner

@sbdchd sbdchd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 998408e into sbdchd:main Jan 23, 2022
@last-partizan last-partizan deleted the fix-filefield-typing branch January 23, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@last-partizan @sbdchd