Skip to content

feat(plasma-temple): Support onboarding page in StateLayout component #1150

Merged
merged 2 commits into from
Mar 30, 2022
Merged

feat(plasma-temple): Support onboarding page in StateLayout component #1150

merged 2 commits into from
Mar 30, 2022

Conversation

kvpolyanskiy
Copy link
Contributor

@kvpolyanskiy kvpolyanskiy commented Mar 17, 2022 •
edited by SberDevices-Eva

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/plasma-temple@1.47.0-canary.1150.a16229fa650b0fb7975f30ad0050bbc58528ef8f.0
# or 
yarn add @sberdevices/plasma-temple@1.47.0-canary.1150.a16229fa650b0fb7975f30ad0050bbc58528ef8f.0

@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited

Codecov Report

Merging #1150 (88c9d0f) into master (105d741) will decrease coverage by 0.76%.
The diff coverage is 94.68%.

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   89.54%   88.78%   -0.77%     
==========================================
  Files         414      430      +16     
  Lines        5566     5830     +264     
  Branches     1610     1674      +64     
==========================================
+ Hits         4984     5176     +192     
- Misses        581      653      +72     
  Partials        1        1
Flag Coverage Δ
plasma-b2c 95.86% <ø> (ø)
plasma-core 94.95% <77.77%> (-0.06%) ⬇️
plasma-temple 81.51% <95.45%> (-0.94%) ⬇️
plasma-ui 94.42% <ø> (ø)
plasma-web 96.11% <77.77%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...RecommendationsItem/ProductRecommendationsItem.tsx 89.28% <ø> (ø)
...src/components/StateLayout/StateLayout@sberbox.tsx 100.00% <ø> (ø)
.../components/StateLayout/StateLayout@sberportal.tsx 100.00% <ø> (ø)
...es/plasma-temple/src/pages/ErrorPage/ErrorPage.tsx 100.00% <ø> (ø)
...ages/plasma-temple/src/pages/GridPage/GridPage.tsx 82.35% <ø> (ø)
.../ItemPage/components/ItemEntities/ItemEntities.tsx 100.00% <ø> (ø)
...ages/ItemPage/components/ItemEntity/ItemEntity.tsx 100.00% <ø> (ø)
...ges/plasma-temple/src/registry/registry@sberbox.ts 100.00% <ø> (ø)
.../plasma-temple/src/registry/registry@sberportal.ts 100.00% <ø> (ø)
...Item/ItemEntities/ItemEntity/ItemEntity@common.tsx 64.28% <64.28%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afb09d...88c9d0f. Read the comment docs.

@kvpolyanskiy kvpolyanskiy changed the title Feat.onboarding feat(plasma-temple): Support onboarding page in StateLayout component Mar 17, 2022
@kvpolyanskiy kvpolyanskiy force-pushed the feat.onboarding branch 2 times, most recently from eb66acc to 3fd473f Compare March 17, 2022 13:57
@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1150/
ui storybook: http://plasma.sberdevices.ru/pr-1150/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1150/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1150/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1150/temple-storybook/

@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1150/

@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1150/
ui storybook: http://plasma.sberdevices.ru/pr-1150/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1150/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1150/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1150/temple-storybook/

@kvpolyanskiy kvpolyanskiy marked this pull request as ready for review March 18, 2022 13:50
@kvpolyanskiy kvpolyanskiy added the RFT PR: Ready for test label Mar 21, 2022
@seryoshka seryoshka added TESTED PR: Testing is done and removed RFT PR: Ready for test labels Mar 29, 2022
@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1150/

@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1150/
ui storybook: http://plasma.sberdevices.ru/pr-1150/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1150/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1150/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1150/temple-storybook/

@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1150/

@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1150/
ui storybook: http://plasma.sberdevices.ru/pr-1150/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1150/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1150/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1150/temple-storybook/

@kvpolyanskiy kvpolyanskiy merged commit a7c04b3 into master Mar 30, 2022
@kvpolyanskiy kvpolyanskiy deleted the feat.onboarding branch March 30, 2022 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LamaEats LamaEats LamaEats approved these changes

@VladislavPetyukevich VladislavPetyukevich VladislavPetyukevich approved these changes

@seryoshka seryoshka Awaiting requested review from seryoshka seryoshka is a code owner

@dakhetov dakhetov Awaiting requested review from dakhetov

Assignees
No one assigned
Labels
TESTED PR: Testing is done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kvpolyanskiy @SberDevices-Eva @LamaEats @VladislavPetyukevich @seryoshka