Handle Windows python's closure of broadcast socket #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform: Windows 10 64-bit
Python version: 3.9.10
Problem: Under Windows, the UDP broadcast socket is closed asynchronously and may not be closed by the time a second discovery is initiated. This occurs even though the SO_REUSEADDR socket option is specified. This appears to be unique to Windows - Linux-based environments operate normally.
Observed output:
Steps to reproduce this:
Proposed fix: Wait for Protocol::connection_lost() to be invoked before considering the socket closed