Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint for React locally #37

Merged
merged 6 commits into from
Nov 13, 2019
Merged

Add eslint for React locally #37

merged 6 commits into from
Nov 13, 2019

Conversation

ivanoblomov
Copy link
Collaborator

Goal

Enable running the linter locally to save a CI run.

Approach

Installed eslint and configured it for React via:

Deployment

Run the linter locally with:

npm run lint

@ivanoblomov ivanoblomov added the enhancement New feature or request label Nov 13, 2019
@ivanoblomov ivanoblomov mentioned this pull request Nov 13, 2019
Closed
@sblackstealth
Copy link
Owner

looks good to me great approach

@sblackstealth sblackstealth merged commit a8e59ae into master Nov 13, 2019
@sblackstealth sblackstealth deleted the eslint-for-react branch November 13, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@husheric husheric Awaiting requested review from husheric

@sblackstealth sblackstealth Awaiting requested review from sblackstealth

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanoblomov @sblackstealth