Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: indication of the beginning of the LED strip #58

Closed
whakru opened this issue Jan 8, 2022 · 7 comments
Closed

[Feature request]: indication of the beginning of the LED strip #58

whakru opened this issue Jan 8, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request feature request

Comments

@whakru
Copy link

whakru commented Jan 8, 2022

Is your feature request related to a problem? Please describe

It is very inconvenient to indent the first LED.

Очень не удобно делать отступ первого светодиода.

Describe the solution you'd like

Add a check mark in the corners to indicate the start of the LED strip. For example, bottom left, bottom right, and so on.
Can be implemented as a selection in the corner of the monitor on the settings screen.

Добавьте галочку в углах, указывающий начало светодиодной ленты. Например слева снизу, справа снизу и так далее.
Можно реализовать в виде выбора в углу монитора на экране настроек.

Describe alternatives you've considered

No response

@sblantipodi
Copy link
Owner

sblantipodi commented Jan 9, 2022

I agree with this... I will do it, thanks!

@sblantipodi sblantipodi added the enhancement New feature or request label Jan 9, 2022
@whakru
Copy link
Author

whakru commented Jan 9, 2022

I agree with this... I will do it, thanks!

You can make a drop-down list next to the direction.

sblantipodi added a commit that referenced this issue Jan 23, 2022
@sblantipodi
Copy link
Owner

sblantipodi commented Jan 23, 2022

this feature request will be closed on the next release.

image

there is now an indication of the corner where the first led is.
thank you for the suggestion! much appreciated.

@whakru
Copy link
Author

whakru commented Jan 23, 2022

very cool!
just do not remove the possibility of a shift (in numbers). you can add a "manual shift" item where the user manually selects the desired shift of the LEDs.

@sblantipodi
Copy link
Owner

@whakru sure, there will be a combobox that let you select
"bottom left, bottom center, bottom right, upper right, upper left".

once selected an item Firefly automatically calculate the correct LED offset but you can manually enter your own value if you prefer. :)

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@sblantipodi
Copy link
Owner

closed by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request
Projects
None yet
Development

No branches or pull requests

2 participants