Merge pull request jsmestad#63 from Shumkov/patch-1

other_id can be a string
sbleon · Jan 30, 2013 · d5e5fb9 · d5e5fb9
2 parents b32bbe5 + a2347e3
commit d5e5fb9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/pivotal-tracker/story.rb b/lib/pivotal-tracker/story.rb
@@ -39,7 +39,7 @@ def find(param, project_id)
     element :labels, String
     element :jira_id, Integer
     element :jira_url, String
-    element :other_id, Integer
+    element :other_id, String
     element :integration_id, Integer
     element :deadline, DateTime # Only available for Release stories
 

diff --git a/spec/pivotal-tracker/story_spec.rb b/spec/pivotal-tracker/story_spec.rb
@@ -185,8 +185,13 @@ def story_for(attrs)
         story_for(:labels => "abc")["labels"].should == "abc"
       end
 
-      it "should include other_id" do
-        story_for(:other_id => 10)["other_id"].should == "10"
+      describe "should include other_id" do
+        it "when passed a string" do
+          story_for(:other_id => "aa10bb")["other_id"].should == "aa10bb"
+        end
+        it "when passed an integer" do
+          story_for(:other_id => 10)["other_id"].should == "10"
+        end
       end
 
       it "should include integration_id" do