Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak somewhat confusing variable name #93

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Tweak somewhat confusing variable name #93

merged 1 commit into from
Jan 27, 2021

Conversation

DavisVaughan
Copy link
Collaborator

Closes #92

@DavisVaughan
Copy link
Collaborator Author

@sboysel would you like me to initiate a fredr CRAN release?

@DavisVaughan DavisVaughan merged commit 166572e into master Jan 27, 2021
@DavisVaughan DavisVaughan deleted the fix/confusing-name branch January 27, 2021 13:21
@sboysel
Copy link
Owner

sboysel commented Jan 27, 2021

Yes a new CRAN release seems appropriate. Is the recommended tool these days devtools::release() or are you submitting manually? Thanks!

@DavisVaughan
Copy link
Collaborator Author

You could start with usethis::use_release_issue(version = "2.0.1"), which gives you a nice checklist of things to do.

Do you want to do it, or should I?

@sboysel
Copy link
Owner

sboysel commented Jan 28, 2021

Why don't you take care of this one (I will monitor email) and I can take care of them after this time. Not have a GitHub PAT and I'm not 100% on what usethis::use_release_issue() is doing under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sboysel sboysel sboysel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

M2 not FedFunds
2 participants
@DavisVaughan @sboysel