Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libmediainfo.so to library_paths for Linux (actually Termux) #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wdscxsj
Copy link

@wdscxsj wdscxsj commented Feb 2, 2024

The libmediainfo package of Termux uses libmediainfo.so rather than libmediainfo.so.0.

@sbraz
Copy link
Owner

sbraz commented Feb 3, 2024

Thanks, I'll fix the CI and I'll look into this. Any idea why Termux does this whereas other distributions ? On Gentoo and Arch Linux, it looks like this:

libmediainfo.so:       symbolic link to libmediainfo.so.0.0.0
libmediainfo.so.0:     symbolic link to libmediainfo.so.0.0.0
libmediainfo.so.0.0.0: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=60a5cbbc464287dbefc9482f3a9f4c60a8a4d64f, stripped

@wdscxsj
Copy link
Author

wdscxsj commented Feb 3, 2024

Thanks for the help! Actually I'm not sure, but perhaps to save a tiny bit of space? On my phone, locate libmediainfo shows this:

/data/data/com.termux/files/usr/lib/libmediainfo.so
/data/data/com.termux/files/usr/lib/pkgconfig/libmediainfo.pc
/data/data/com.termux/files/usr/share/doc/libmediainfo
/data/data/com.termux/files/usr/share/doc/libmediainfo/LICENSE
/data/data/com.termux/files/usr/var/lib/dpkg/info/libmediainfo.list
/data/data/com.termux/files/usr/var/lib/dpkg/info/libmediainfo.md5sums

@sbraz
Copy link
Owner

sbraz commented Feb 3, 2024

I think I found the QA issue: can you please cherry-pick d02fb74 and push again?

@wdscxsj
Copy link
Author

wdscxsj commented Feb 3, 2024

I add an explicit type annotation to library_paths so that it won't be deduced to be Tuple[str]. mypy has really sharp eyes. 😄

@sbraz
Copy link
Owner

sbraz commented Feb 11, 2024

Hello @valpogus, I see you've committed to https://github.com/termux/termux-packages/commits/master/packages/libmediainfo/build.sh quite a bit. Could you please tell me why there is no libmediainfo.so.0 file on Termux? Is that some kind of optimization? I'd first want to make sure that this is not a bug in Termux before adding the path to pymediainfo.

@sbraz
Copy link
Owner

sbraz commented Feb 11, 2024

I add an explicit type annotation to library_paths so that it won't be deduced to be Tuple[str]. mypy has really sharp eyes. 😄

Oh yeah indeed. It took me a while to understand what was happening so I added a long comment in 2a4650e. I will push it as soon as I check that the CI works with it.

@valpogus
Copy link

Hello @valpogus, I see you've committed to https://github.com/termux/termux-packages/commits/master/packages/libmediainfo/build.sh quite a bit. Could you please tell me why there is no libmediainfo.so.0 file on Termux? Is that some kind of optimization? I'd first want to make sure that this is not a bug in Termux before adding the path to pymediainfo.

Actually, I don't know :). When I first created the mediainfo packages, I also created the soversion-suffixed symlinks mirroring the official DEB packages to be compatible with pymediainfo (see termux/termux-packages#4642). The soversion-suffixed symlinks were later removed on commit termux/termux-packages@bc1264e. Maybe the commiter @xtkoba can provide a reason why. Otherwise, https://gitter.im/termux/dev might be a good place to ask. I am far from an expert on these matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants