Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploads don't appear in the recent changes #106

Closed
sbrl opened this issue Sep 11, 2016 · 1 comment
Closed

Uploads don't appear in the recent changes #106

sbrl opened this issue Sep 11, 2016 · 1 comment
Labels
Area: Code It's got something to do with code bug Squash it quick!
Milestone
v0.12.1

Comments

@sbrl
Copy link
Owner

sbrl commented Sep 11, 2016

For some reasons uploads aren't appearing on the recent changes page. They are showing up in recent-changes.json (thank goodness for that!), but they aren't being rendered for some reason.

We should investigate this issue.
@sbrl sbrl added bug Squash it quick! Area: Code It's got something to do with code labels Sep 11, 2016
@sbrl sbrl added this to the v0.12.1 milestone Sep 11, 2016
@sbrl sbrl closed this as completed in 7e1c343 Sep 11, 2016
@sbrl
Copy link
Owner Author

sbrl commented Sep 11, 2016

It turns out that there we weren't taking one from i to account for the incrementation when we tick over to the next iteration of the main loop after scanning ahead in order to group changes.

It's fixed now!

sbrl added a commit that referenced this issue Oct 18, 2016
@sbrl
Correct rendering of recent changes list. Fixes #106.
9f2efb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Code It's got something to do with code bug Squash it quick!
Projects
None yet
Milestone
v0.12.1
Development

No branches or pull requests
1 participant
@sbrl