Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opensearch #112

Closed
sbrl opened this issue Sep 29, 2016 · 7 comments
Closed

Support opensearch #112

sbrl opened this issue Sep 29, 2016 · 7 comments
Labels
Area: Code It's got something to do with code enhancement Let's make it better!
Milestone

Comments

@sbrl
Copy link
Owner

sbrl commented Sep 29, 2016

If we supported Opensearch, then users would be able to search a wiki from their address bar, which would be seriously cool.

We should look into this to work out how hard it would be to implement.

@sbrl sbrl added enhancement Let's make it better! Area: Code It's got something to do with code labels Sep 29, 2016
@sbrl sbrl added this to the v0.13 milestone Sep 29, 2016
@sbrl
Copy link
Owner Author

sbrl commented Sep 30, 2016

Ewwww that link has all sorts of hard things in it! O.o I don't really want to rewrite the search engine to optionally return the results in XML....! That would add a lot of bloat to Pepperminty Wiki at best.

This page looks like it's much easier to implement and easier to understand. Apparently we don't need to return results in XML / RSS / Atom after all.

We could add a layer of abstraction and write a module if anyone wants it.

@sbrl
Copy link
Owner Author

sbrl commented Sep 30, 2016

Another relevant link: http://www.opensearch.org/Specifications/OpenSearch/1.1

@sbrl
Copy link
Owner Author

sbrl commented Oct 1, 2016

I've attempted this, but doesn't appear to be working correctly 😕

If anyone can help, that would be great!

@ikisler
Copy link
Contributor

ikisler commented May 29, 2017

I can't test this due to work limitations, but could this not be working because your wiki address always includes a path?

According to this page you link to above:

In my case, I always have a URL of https://domain.com/me/whatever/wiki, so I think opensearch will not work using this method?

@sbrl
Copy link
Owner Author

sbrl commented May 29, 2017

Ahhhhh. I think you may be right! I'll take a look at fiddling with the core to remove that pesky path then.
Thanks!

@sbrl
Copy link
Owner Author

sbrl commented Jun 6, 2017

After a bit of fiddling, it's now working! Hooray! Thanks for the help. Turns out I just needed to take a break and come back to it with a fresh mind. And fight with the build system a bit. I really should refactor it a bit.....

@sbrl
Copy link
Owner Author

sbrl commented Jun 6, 2017

I've also added your PR's to the changelog & you to the credits, @ikisler. Thanks again! 😺

@sbrl sbrl closed this as completed Jun 6, 2017
@sbrl sbrl removed the help wanted I need some help with this. label Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code It's got something to do with code enhancement Let's make it better!
Projects
None yet
Development

No branches or pull requests

2 participants