Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I keep getting logged out #113

Closed
sbrl opened this issue Sep 30, 2016 · 2 comments
Closed

I keep getting logged out #113

sbrl opened this issue Sep 30, 2016 · 2 comments
Labels
Area: Code It's got something to do with code bug Squash it quick! enhancement Let's make it better!
Milestone

Comments

@sbrl
Copy link
Owner

sbrl commented Sep 30, 2016

If I'm inactive for a time (or I've just been working on a page for a while), then I get logged out when I next reload the page.

We should allow the user to stay logged in for at least 24 hours.

@sbrl sbrl added bug Squash it quick! enhancement Let's make it better! Area: Code It's got something to do with code labels Sep 30, 2016
@sbrl sbrl added this to the v0.13 milestone Sep 30, 2016
@sbrl
Copy link
Owner Author

sbrl commented Sep 30, 2016

It seems that there are multiple possible causes for this bug:

  • The session cookie could be expiring (See this SO question)
  • The session files could be getting deleted by PHP.

Again, there are multiple solutions:

  • Set a longer expiry date on the session cookie.
  • Make sure that PHP is not deleting the session files early.
  • Add a JS snippet to every page that pings the server every 5 minutes or so to keep the session from expiring. We would need to check if setTimeout measures real time, or whether the timer gets stopped when a page is not focused, as JS get's slowed down / paused when a tab is not active in Chrome.

@sbrl
Copy link
Owner Author

sbrl commented Sep 30, 2016

It look like it's the cookie thing causing this problem!

@sbrl sbrl closed this as completed in e3ccc41 Sep 30, 2016
sbrl added a commit that referenced this issue Oct 18, 2016
… new settings property, 'sessionlifetime', so we need to add in #83 now.
sbrl added a commit that referenced this issue Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code It's got something to do with code bug Squash it quick! enhancement Let's make it better!
Projects
None yet
Development

No branches or pull requests

1 participant