Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search context generation is broken in some instances #30

Closed
sbrl opened this issue Nov 2, 2015 · 7 comments
Closed

Search context generation is broken in some instances #30

sbrl opened this issue Nov 2, 2015 · 7 comments
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!
Milestone
v0.12.1

Comments

@sbrl
Copy link
Owner

sbrl commented Nov 2, 2015

Generating search result context appears to have broken when I tried it today on Windows.
@sbrl sbrl added the bug Squash it quick! label Nov 2, 2015
@sbrl
Copy link
Owner Author

sbrl commented Nov 9, 2015

This may have something to do with a required PHP extension that I am not aware of. Does anyone else experience this issue? Perhaps I can track it down if we gather more data.

@sbrl sbrl changed the title Context generation is broken in some instances Search context generation is broken in some instances Dec 6, 2015
@sbrl
Copy link
Owner Author

sbrl commented Mar 21, 2016 •
edited

It appears that the mbstring module is required. Could this have been what was causing the issue? I don't think so - it's absence caused a crash just now. I would have noticed sooner if this was the case.

Further investigation is definitely needed.

@sbrl
Copy link
Owner Author

sbrl commented Jun 22, 2016

Odd. This issue occurs even with the mbstring module loaded. It's like the search context isn't even there! Furthermore, there aren't any errors or warnings whatsoever. This looks like a rather difficult bug to track down.

@sbrl sbrl added the Area: Code It's got something to do with code label Jun 26, 2016
@sbrl
Copy link
Owner Author

sbrl commented Aug 19, 2016

Yeah, this appears to be happening on the new personal wiki I'm currently migrating. Somethings up!

@sbrl sbrl mentioned this issue Aug 19, 2016
Closed
@sbrl
Copy link
Owner Author

sbrl commented Aug 19, 2016

Umm wat?

We have confirmation that this issue is not due to a missing module - on sufficiently complex wikis some results may have the context shown, and for others in the same search the context will be missing.

@sbrl sbrl added this to the v0.12.1 milestone Aug 19, 2016
sbrl added a commit that referenced this issue Aug 19, 2016
@sbrl
Half fixed search context generation for #30.
c501791 
The problem: The matches were being sorted in the wrong direction.
Next up we need to improve the context generation, as there are several contexts that are being generated without the keywork in question in them.
@sbrl
Copy link
Owner Author

sbrl commented Aug 19, 2016

Found the problem! The matches in the text were being sorted in the wrong direction.

Now we just need to solve a new issue of contexts that are generated that don't contain the keyword in question. This bug just gets stranger and stranger.

@sbrl sbrl closed this as completed in b8dd51d Aug 19, 2016
@sbrl
Copy link
Owner Author

sbrl commented Aug 19, 2016 •
edited

Yay! I've finally fixed this one once and for all. The epic tale of the broken search context generation has now been concluded.

Goodbye and good night!

sbrl added a commit that referenced this issue Aug 19, 2016
@sbrl
Updated changelog.
7f41f41 
Fix #30. This was actually done in the last commit, but it didn't close automagically.
@sbrl sbrl added the fixed It's fixed! label Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Code It's got something to do with code bug Squash it quick! fixed It's fixed!
Projects
None yet
Milestone
v0.12.1
Development

No branches or pull requests
1 participant
@sbrl