Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode accented characters in page names #95

Closed
sbrl opened this issue Aug 19, 2016 · 1 comment
Closed

Allow unicode accented characters in page names #95

sbrl opened this issue Aug 19, 2016 · 1 comment
Labels
Area: Code It's got something to do with code enhancement Let's make it better!

Comments

@sbrl
Copy link
Owner

sbrl commented Aug 19, 2016

We really should allow page names to contain unicode characters. Currently, we try to avoid them in order to make sure that the filenames we use to save to disk are safe. There are 2 approaches here:

  1. Find some method of escaping special characters in filenames (lots of work - we'd have to go over practically the whole codebase and change it all 😐
  2. Draw up a list of unsafe characters that aren't allowed in filenames (not so much work).
@sbrl sbrl added enhancement Let's make it better! Area: Code It's got something to do with code labels Aug 19, 2016
@sbrl sbrl changed the title Allow unicode accented character in page names Allow unicode accented characters in page names Aug 21, 2016
@sbrl
Copy link
Owner Author

sbrl commented Aug 21, 2016

This shouldn't be too difficult actually. The tricky part is making sure that we don't miss any characters that shouldn't be allowed. The Wikipedia Page on filenames is a good place to start.

@sbrl sbrl closed this as completed in 60b4bbf Aug 21, 2016
sbrl added a commit that referenced this issue Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code It's got something to do with code enhancement Let's make it better!
Projects
None yet
Development

No branches or pull requests

1 participant