Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for nushell #130

Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat: Add support for nushell #130

merged 3 commits into from
Jul 12, 2023

Conversation

Miuler
Copy link
Contributor

@Miuler Miuler commented Mar 25, 2023 •
edited
Loading

Add basic support for nushell

Resolve #121

@Miuler Miuler mentioned this pull request Mar 28, 2023
Closed
@sbstp
Copy link
Owner

sbstp commented Mar 28, 2023

The prompt does not work in nushell

@Miuler
Copy link
Contributor Author

Miuler commented Mar 28, 2023

The prompt does not work in nushell

This pull request adds basic support for nushell. I use the starship, so I didn't need to change the native prompt in nushell XD. Do you need a support prompt to approve this PR?

@Miuler
Copy link
Contributor Author

Miuler commented Mar 29, 2023

I have added support for prompt in nushell

@Miuler Miuler force-pushed the feat/support-nushell branch 2 times, most recently from 9fa2880 to 01e05dd Compare March 31, 2023 00:57
@Miuler
Copy link
Contributor Author

Miuler commented Mar 31, 2023 •
edited
Loading

I fixed the remove_matchess problem. It's unstable because it's a new API, but I replaced it with a function called reclace.

@Miuler
🐛 fix(nushell): Replace remove_matches by replace
01e05dd 
Because `remove_matches` is unstable, because is new API
@Miuler
Copy link
Contributor Author

Miuler commented Apr 1, 2023

Please @sbstp, can you Review this pull?

@Miuler
Copy link
Contributor Author

Miuler commented Apr 12, 2023

@sbstp, what is needed to approve this pull request?

@Miuler
Copy link
Contributor Author

Miuler commented Apr 17, 2023

I think you are too busy to answer :(

@Miuler
Copy link
Contributor Author

Miuler commented May 27, 2023

@sbstp, what is needed to approve this pull request? It has been two months

@sbstp sbstp merged commit c2d565c into sbstp:master Jul 12, 2023
@Miuler Miuler deleted the feat/support-nushell branch July 24, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please support nushell
2 participants
@Miuler @sbstp