Fix sbt bug #6453 #319
Merged
Fix sbt bug #6453 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user pointed out that if two globs were specificed that looked like a/b.txt and a/b/**, then FileTreeView.list(globs) would not return the children in the subdirectory a/b. There is an optimization that FileTreeView.list makes when handling paths that may have multiple globs matching the same prefix. At the fork point (which in the example above is the directory a), we save all of the files that we find in there so that as the recursive algorithm proceeds, it doesn't necessarily need to make an additional syscall to determine whether the next file it wants to look at is a path or a directory. The problem here though was that we incorrectly passed the parent (fork) path into the listPath method rather than the path itself.
|
I tested in a local sbt build that sbt/sbt#6453 was fixed by this change. |
eed3si9n
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user pointed out that if two globs were specificed that looked like
a/b.txt and a/b/**, then FileTreeView.list(globs) would not return the
children in the subdirectory a/b. There is an optimization that
FileTreeView.list makes when handling paths that may have multiple globs
matching the same prefix. At the fork point (which in the example above
is the directory a), we save all of the files that we find in there so
that as the recursive algorithm proceeds, it doesn't necessarily need to
make an additional syscall to determine whether the next file it wants
to look at is a path or a directory. The problem here though was that we
incorrectly passed the parent (fork) path into the listPath method
rather than the path itself.