Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 #333

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Scala 3 #333

merged 1 commit into from
Nov 15, 2021

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Nov 14, 2021

No description provided.

Comment on lines -242 to +249
@tailrec
override final def poll(
duration: Duration,
filter: FileEvent[T] => Boolean
): Seq[FileEvent[T]] = pollImpl(duration, filter)
@tailrec
private[this] final def pollImpl(
duration: Duration,
filter: FileEvent[T] => Boolean
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import org.scalatest.flatspec.AnyFlatSpec
import sbt.io.syntax._

class CopyDirectorySpec extends AnyFlatSpec with Diagrams {
class CopyDirectorySpec extends AnyFlatSpec {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diagram assert does not work with Scala 3 (compile error) 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a known bug in ScalaTest?

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eed3si9n eed3si9n merged commit ff50334 into sbt:develop Nov 15, 2021
@xuwei-k xuwei-k deleted the scala-3 branch November 15, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants