Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matching method is inaccessible from build.sbt #83

Closed
eed3si9n opened this issue Apr 13, 2017 · 4 comments
Closed

matching method is inaccessible from build.sbt #83

eed3si9n opened this issue Apr 13, 2017 · 4 comments
Assignees

Comments

@eed3si9n
Copy link
Member

Ref #78
matching became private[sbt], so it's no longer accessible. Prior to the change at least we could get to it via importing internal.

@dwijnand
Copy link
Member

Ah, the use case suffering from this change is our own scripted tests..

Given the use case is so niche, how do you feel about us finding a call-site workaround, by defining a forwarder in a project/*.Scala util, rather than messing with the encoding here?

@eed3si9n
Copy link
Member Author

Since there there are a bunch tests that use it, I think we should just expose it (and any other enrichment that looks safe) out since we're doing it for one method.

@dwijnand
Copy link
Member

Without intending to sound facetious, do you have criteria (or a rule of thumb) for what you consider to be safe?

@eed3si9n
Copy link
Member Author

Something that has concrete meaning and won't change as we might add fields in the future would be relatively safe, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants