-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose RichUpdateReport & DependencyFilter #78
Conversation
|
||
/** Obtains all successfully retrieved files matching all provided filters. An unspecified argument matches all files. */ | ||
def select(configuration: ConfigurationFilter = configurationFilter(), module: ModuleFilter = moduleFilter(), artifact: ArtifactFilter = artifactFilter()): Seq[File] = | ||
def select( | ||
configuration: ConfigurationFilter = configurationFilter(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid default args.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is overloading ok? 3 versions with (undefaulted) ConfigurationFilter, ModuleFilter and ArtifactFilter?
My motivation is (attempts at) source-compatibility with 0.13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 version with all 3 undefaulted too. That would cover the 3 use-cases I see in Scala.js (both its build and its sbt plugins).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea. Overloading is fine.
Fixes #42