Expose more in RichUpdateReport #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
requested changes
Apr 13, 2017
| @@ -15,10 +18,10 @@ final class RichUpdateReport(report: UpdateReport) { | |||
| import DependencyFilter._ | |||
|
|
|||
| /** Obtains all successfully retrieved files in all configurations and modules. */ | |||
| private[sbt] def allFiles: Seq[File] = matching(DependencyFilter.allPass) | |||
| def allFiles: Seq[File] = matching(DependencyFilter.allPass) | |||
|
|
||
| /** Obtains all successfully retrieved files in configurations, modules, and artifacts matching the specified filter. */ | ||
| private[sbt] def matching(f: DependencyFilter): Seq[File] = select0(f).distinct | ||
| def matching(f: DependencyFilter): Seq[File] = select0(f).distinct |
| @@ -50,11 +63,19 @@ final class RichUpdateReport(report: UpdateReport) { | |||
| .withMissingArtifacts(modReport.missingArtifacts) | |||
| } | |||
|
|
|||
| private[sbt] def toSeq: Seq[(String, ModuleID, Artifact, File)] = | |||
| for (confReport <- report.configurations; modReport <- confReport.modules; (artifact, file) <- modReport.artifacts) yield (confReport.configuration, modReport.module, artifact, file) | |||
| def toSeq: Seq[(String, ModuleID, Artifact, File)] = | |||
There was a problem hiding this comment.
toVector and then add toSeq that calls toVector.
|
|
||
| private[sbt] def allMissing: Seq[(String, ModuleID, Artifact)] = | ||
| for (confReport <- report.configurations; modReport <- confReport.modules; artifact <- modReport.missingArtifacts) yield (confReport.configuration, modReport.module, artifact) | ||
| def allMissing: Seq[(String, ModuleID, Artifact)] = |
| (artifact, file) <- mReport.artifacts | ||
| if f(cReport.configuration, mReport.module, artifact) | ||
| } yield { | ||
| if (file == null) |
There was a problem hiding this comment.
I think we should either use Option(file).orElse { ... } or put { .. } around sys.error.
eed3si9n
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83