Log resolving messages at debug level #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For great justice.
|
Note that this is in sbt 1.0: https://github.com/sbt/sbt/pull/2747/files I personally don't have any strong opinions on this, so I abstain. |
huntc
approved these changes
Sep 29, 2016
eed3si9n
reviewed
Sep 29, 2016
There was a problem hiding this comment.
As @dwijnand wrote I've already removed Ivy logging on CI environment here - sbt/sbt#2747
So this means that when you start sbt and it's trying to resolve plugins etc it's just going to sit and freeze, which I don't think is something you'd want. I don't know "Resolving ..." is the right implementation but we should display some stuff on the screen to indicate that it's doing work while Ivy is resolving and downloading.
dwijnand
approved these changes
Mar 10, 2017
There was a problem hiding this comment.
I'm happier to accept this change given https://github.com/sbt/launcher/pull/27/files. Thanks, friends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For great justice.