Deduplicate and remove deprecations in IvyActions
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cleanCachedResolutionCache` and `clean` were doing extra work because `clean` does only need to clean the cache in the configuration (that is a class parameter).
This commit reduces the code duplication in `updateEither` which was duplicating a good deal of the resolution logic to deal with the different resolution mechanisms: the simple one and the cached one. It also unifies the signatures of the helpers that are invoked by `updateEither`, removing the weirdness of the different return type signatures and ad-hoc logic handling.
This commit removes the second instance of `retrieve` that was private and unused, therefore reducing the API surface of `IvyActions`.
Plus, remove deprecated method using `ResolveException`.
eed3si9n
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a series of commits with the goal of cleaning up this part of the
API.
The reason why I'm doing this is because I found it very difficult to
understand what the code was doing and I need to implement some hooks for the
dependency lock file.
These are the tasks covered in this commit:
updateEitherIvyActionsUnresolvedWarningResolveExceptionprivate[sbt]retrieveupdateEither