-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use value
instead of DependencyResolution
#87
Comments
Reproduces sbt#87
Great work. Just to move the needle on this a bit, I shared what I think is the change you had in mind at #123 - and it indeed demonstrates the problem of not having licensing information populated (which is presumably caused by coursier/coursier#1790, haven't dug into that part yet). If you're into that sort of thing, you can |
It indeed looks like https://github.com/coursier/sbt-coursier/blob/main/modules/lm-coursier/src/main/scala/lmcoursier/internal/SbtUpdateReport.scala#L124 only looks at licenses defined in the pom of the artifact itself (e.g. it sees the license of junit) but if that is missing it does not look in the parent pom (e.g. commons-lang3 and jackson-databind have no licenses) |
so I guess the question is where we should implement https://maven.apache.org/pom.html#inheritance . Without understanding the context too well, it seems reasonable to do this at https://github.com/coursier/sbt-coursier/blob/main/modules/lm-coursier/src/main/scala/lmcoursier/internal/SbtUpdateReport.scala#L255, i.e. after looking up the project in the |
Reproduces sbt#87
As explained in #86 it would be ideal to just use the
update
task in order to retrieve the dependencies from the report however we are blocked by coursier/coursier#1790 (tl;dr coursier doesn't populate license information fromivy.xml
descriptor files).Using Ivy Resolution is also causing other problems, i.e. for dependencies that use
packaging.type
there is a workaround at sbt/sbt#3618 (comment) however this doesn't seem to work with ivy resolution done by sbt plugins (I think that because of classloader isolation maybe the system properties aren't propogating?)The text was updated successfully, but these errors were encountered: