Simplify link validator config #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, ... though it works fine on my machine and is at https://repo1.maven.org/maven2/net/runne/site-link-validator_2.13/0.2.4/ . It was released today though, perhaps some cache is slower to pick it up? |
|
purged the cache and re-ran the action - not sure which of those fixed it :) |
He-Pin
approved these changes
Jul 2, 2024
|
lgtm |
Roiocam
reviewed
Jul 2, 2024
| @@ -42,4 +42,4 @@ jobs: | |||
| sbt -Dpekko.genjavadoc.enabled=true -Dpekko.genlicensereport.enabled=true "Javaunidoc/doc; Compile/unidoc; docs/paradox" | |||
There was a problem hiding this comment.
if we don't validate license report links, then do we need to generate them?
There was a problem hiding this comment.
still probably useful to build them to prove they don't cause a build failure
It may not be free for ever but at the moment, we are not limited on build time in GitHub CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.