Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With the latest version (1.9.5), Docker / version is detected as "not used" by sbt #1464

Closed
guizmaii opened this issue Oct 8, 2021 · 0 comments · Fixed by #1465
Closed

Comments

@guizmaii
Copy link
Contributor

guizmaii commented Oct 8, 2021

Expected behaviour

We have some definitions for our Docker build:

object BuildHelper {
  lazy val dockerSettings = Seq(
    Docker / maintainer       := "...",
    Docker / daemonUser       := "...",
    Docker / dockerRepository := Some("..."),
    Docker / packageName      := packageName.value,
    dockerUpdateLatest        := false,
    dockerExposedPorts        := Seq(8080),
    dockerBaseImage           := "ubuntu:latest",
    Docker / version          := s"$release-$version",  // this is the line 63 that sbt talks about
  )
}

I just updated to the latest version of sbt-native-packager and since the update sbt tells me this:

[warn] there's a key that's not used by any other settings/tasks:
[warn]  
[warn] * app-build / Docker / version
[warn]   +- BuildHelper.scala:63

I had a quick look at the changes between 1.9.4 and 1.9.5. It could be because of this change:
v1.9.4...v1.9.5#diff-b866751bc91854625b6a5d821ae6a4df02736ceb3581779d81319caee1d9d2cdR100

This Option((version in Docker).value) piece of code have been changed for Option((version).value).
Should it be Option((Docker / version).value) instead?

cc @frankivo

guizmaii added a commit to guizmaii/sbt-native-packager that referenced this issue Oct 8, 2021
@guizmaii guizmaii mentioned this issue Oct 8, 2021
muuki88 added a commit that referenced this issue Oct 14, 2021
* Fix #1464

* fmt

* fmt

* fmt

Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com>
littleRoundaer added a commit to littleRoundaer/sbt-native-packager that referenced this issue Jul 19, 2022
* Fix sbt/sbt-native-packager#1464

* fmt

* fmt

* fmt

Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant