Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1464 #1465

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Fix #1464 #1465

merged 5 commits into from
Oct 14, 2021

Conversation

guizmaii
Copy link
Contributor

@guizmaii guizmaii commented Oct 8, 2021

Fixes #1464

(Docker / dockerRepository).value,
(Docker / dockerUsername).value,
(Docker / packageName).value,
Option((Docker / version).value)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1464

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 😊

@muuki88
Copy link
Contributor

muuki88 commented Oct 8, 2021

Time to remove the 0.13.x support....

@guizmaii
Copy link
Contributor Author

@muuki88 What is it missing for you to merge? This is quite an annoying bug that can go unnoticed and can break people versioning schemes.

@muuki88
Copy link
Contributor

muuki88 commented Oct 11, 2021

I though we had the SBT slash syntax already in use. But appearently we don't. So I removed the sbt 0.13.x cross build for now

@muuki88 muuki88 merged commit 89c3180 into sbt:master Oct 14, 2021
@muuki88
Copy link
Contributor

muuki88 commented Oct 14, 2021

1.9.6 is on its way

@guizmaii guizmaii deleted the fix_1464 branch October 14, 2021 10:57
@guizmaii
Copy link
Contributor Author

Thanks @muuki88 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With the latest version (1.9.5), Docker / version is detected as "not used" by sbt
2 participants