Started refactoring of archetypes templates #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still unused code left :)
| */ | ||
| def defaultStartScriptTemplate(loader: ServerLoader, defaultLocation: File): URL = | ||
| if (defaultLocation.exists) defaultLocation.toURI.toURL | ||
| else templateUrl(startScript, loader) get |
There was a problem hiding this comment.
Should always have getOrElse sys.error("Something useful here") or force downstream error. Since this is very user-facing project, these kinds of "None.get exception" messages can be frustrating (although practically shoudln't happen, murphy's law says it will).
|
I like the direction of this pull request! |
|
Awesome! I love that travis CI is working here for us too. Thanks for the fixes. |
jsuereth
added a commit
that referenced
this pull request
Jan 22, 2014
Started refactoring of archetypes templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think? I didn't test it yet, just want to structure the code a bit.