Discard files that are not jars #1565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your module has libraryDependencies that are not JARs, they
end up on the classpath (they even get renamed during staging)
when they're not jar.
For instance, consider this dependency:
```
libraryDependencies += "com.google.protobuf" % "protoc" % "3.18.2" withExplicitArtifacts Vector(
Artifact("protoc").withType("jar").withExtension("exe").withClassifier(Some("osx-aarch_64"))
)
```
When you add that, you'll get a file an `Attributed[File]` at the following location:
`/path/to/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/google/protobuf/protoc/3.18.2/protoc-3.18.2-osx-aarch_64.exe`
When the `universalDepMappings` logic runs, it keeps the file (even it is not
a jar, but furthermore, create a jar name for it like: `com.google.protobuf.protoc-3.18.2-osx-aarch_64.jar`
This PR is to avoid this issue, I did not create an issue for this
because of the overhead of it. If you think this is not valid
we can just close the PR.
It did not cause me any issue, as the file is on the classpath
but the JVM probably ignores it because it's not a jar and the
app is working correctly. It's just annoying that the file is
renamed in packaging
|
Hi @daddykotex, Thank you for your contribution! We really value the time you've taken to put this together. We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it. |
|
Yeah... I feared the attempted fix would be too naive (ignores .JAR or .`zip) and as the failed tests highlight it, it ignores the directories I guess |
|
Will close, this can serve as documentation that there is an issue but I doubt anybody will run into that. I've personally implemented my solution in a way that does not require adding it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your module has libraryDependencies that are not JARs, they end up on the classpath (they even get renamed during staging) when they're not jar.
For instance, consider this dependency:
(located on maven central)
When you add that, you'll get a file an
Attributed[File]at the following location:/path/to/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/google/protobuf/protoc/3.18.2/protoc-3.18.2-osx-aarch_64.exeWhen the
universalDepMappingslogic runs, it keeps the file (even it is not a jar, but furthermore, create a jar name for it like:com.google.protobuf.protoc-3.18.2-osx-aarch_64.jarThis PR is to avoid this issue, I did not create an issue for this because of the overhead of it. If you think this is not valid we can just close the PR.
It did not cause me any issue, as the file is on the classpath but the JVM probably ignores it because it's not a jar and the app is working correctly. It's just annoying that the file is renamed in packaging