Fix rpmbuild syntax in RpmHelper #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying this out now. I'm using Fedora 11, so i've seen Mac software have odd BSD-ish command line parsers vs. the linux hippies. Let's see what happen! |
jsuereth
added a commit
that referenced
this pull request
Jan 19, 2012
Fixed rpmbuild args for MacOS * RPM build process forks avoid = now * New debug commands This commit courtesy of the awesome @mtye
|
I'm using 4.9.1.2 apparently. The merge works for 4.9, so I pulled it. |
|
Cool. I'm glad this syntax works for both 4.9 and 5.0; it's much simpler that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got another one for you, Josh...
I tried using the
rpm:package-bintask and got this error:According to the man doc for the version of rpmbuild I'm using (5.0.0, Mac OS X Snow Leopard), the syntax for the
buildrootoption is--buildroot DIRECTORY, not--buildroot=DIRECTORY.I've been told (by colleagues more knowledgeable than I) that there are unfortunate behavioral inconsistencies between various versions of RPM - notably 4.9 vs. 5.0. However, they all seem to share the same option syntax.
So, my question is: Does the existing
RpmHelper.buildPackagecode work for you, and if so, on what platform/RPM version?If it does work for you, then it may be necessary to add an
rpmVersionsetting to the plugin and adjust therpmbuildargs to accomodate the syntax differences between versions. Alternately, you could just mandate in the documentation that the plugin only works with specific version(s) of RPM.If the existing code doesn't work for you, either, pull my patch and see if that fixes it. I also added some debug logging to help diagnose errors with the RPM packaging.