-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding rpm override script tests #891
Conversation
Documentation is inconsistent too. http://www.scala-sbt.org/sbt-native-packager/archetypes/cheatsheet.html#service-manager I'll take a look at this tests. |
I think there is a problem with a scope of |
@kardapoltsev yeah, the documentation is outdated. One part gets fixed in #889
Very good catch! @mackler tests are looking good. Debian would be awesome as well, but you can do this in another PR as well if you like. |
@muuki88 @kardapoltsev I fixed the scope issue in the SystemVPlugin and the override seems to work now :) Thanks for your help. I'll submit another PR with the debian tests over the weekend (need to setup a vagrant instance and do some other setup before updating those tests) |
@@ -65,7 +65,7 @@ object SystemVPlugin extends AutoPlugin { | |||
Seq( | |||
// set the template | |||
linuxStartScriptTemplate := linuxStartScriptUrl( | |||
(sourceDirectory in Compile).value, | |||
(sourceDirectory).value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to remove ()
around sourceDirectory
too (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
The same issue is present in |
LGTM now (: |
commits have been squashed :) |
@muuki88 Are you talking to me about Debian above? If so, I am unclear on what you mean and doubtful that I am competent enough to be of much use. |
Ah, sorry @mackler I was misguided by githubs auto completion ;) @kardapoltsev squashing is not necessary anymore :) Github provides this in the UI now. |
|
@mitch-seymour, thanks! |
I added some tests for checking the override behavior of upstart, systemd, and systemv start scripts for rpm packaging (will circle back around to debian when I have time). It seems that the start script template can only be overridden for the UpstartPlugin and SystemdPlugin. However, the SystemVPlugin does not seem to work (would like verification from someone more experienced with this plugin, who can run these new tests from their own machine).
Would someone please:
Thanks in advance