Adding rpm override script tests

[mitch-seymour]

I added some tests for checking the override behavior of upstart, systemd, and systemv start scripts for rpm packaging (will circle back around to debian when I have time). It seems that the start script template can only be overridden for the UpstartPlugin and SystemdPlugin. However, the SystemVPlugin does not seem to work (would like verification from someone more experienced with this plugin, who can run these new tests from their own machine).

$ cd /path/to/sbt-native-packager
$ sbt # interactive mode
> scripted rpm/override-start-script-upstart # works
> scripted rpm/override-start-script-systemd # works
> scripted rpm/override-start-script-systemv # does not work

Would someone please:

1. Verify the systemv overriding template issue
2. If possible, provide some guidance on a possible fix that I can include in this PR

Thanks in advance

[kardapoltsev]

Documentation is inconsistent too.

http://www.scala-sbt.org/sbt-native-packager/archetypes/cheatsheet.html#service-manager
http://www.scala-sbt.org/sbt-native-packager/archetypes/systemloaders.html#override-start-script

I'll take a look at this tests.

[kardapoltsev]

2. If possible, provide some guidance on a possible fix that I can include in this PR

I think there is a problem with a scope of sourceDirectory. Try to remove in Compile and check if it works for you.
https://github.com/mitch-seymour/sbt-native-packager/blob/master/src/main/scala/com/typesafe/sbt/packager/archetypes/systemloader/SystemVPlugin.scala#L68

[muuki88]

@kardapoltsev yeah, the documentation is outdated. One part gets fixed in #889

I think there is a problem with a scope of sourceDirectory. Try to remove in Compile and check if it works for you.

Very good catch!

@mackler tests are looking good. Debian would be awesome as well, but you can do this in another PR as well if you like.

[mitch-seymour]

@muuki88 @kardapoltsev I fixed the scope issue in the SystemVPlugin and the override seems to work now :) Thanks for your help. I'll submit another PR with the debian tests over the weekend (need to setup a vagrant instance and do some other setup before updating those tests)

[kardapoltsev]

I think it's better to remove () around sourceDirectory too (:

[mitch-seymour]

done :)

[kardapoltsev]

The same issue is present in debianSettings too. Looking for a PR for debian too.
Thank you!

[kardapoltsev]

LGTM now (:
Could you squash your commits please?

[mitch-seymour]

commits have been squashed :)

[mackler]

@muuki88 Are you talking to me about Debian above? If so, I am unclear on what you mean and doubtful that I am competent enough to be of much use.

[muuki88]

Ah, sorry @mackler I was misguided by githubs auto completion ;)

@kardapoltsev squashing is not necessary anymore :) Github provides this in the UI now.
Alexey feel free to merge :)

[kardapoltsev]

squashing is not necessary anymore :) Github provides this in the UI now.
I've missed this update (:

[kardapoltsev]

@mitch-seymour, thanks!