Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated Paradox site contains copy of intermediate theme and HTML files #80

Closed
jonas opened this issue Nov 16, 2016 · 4 comments
Closed

Generated Paradox site contains copy of intermediate theme and HTML files #80

jonas opened this issue Nov 16, 2016 · 4 comments
Labels
bug
Milestone
1.2.0

Comments

@jonas
Copy link
Member

jonas commented Nov 16, 2016

As noted here in lightbend/ssl-config#51 the generated Paradox site contains the intermediate files from running Paradox. For example, the scripted paradox/can-use-paradox fails when applying the following patch in sbt-site:

diff --git i/src/sbt-test/paradox/can-use-paradox/build.sbt w/src/sbt-test/paradox/can-use-paradox/build.sbt
index f15d922..691db2e 100644
--- i/src/sbt-test/paradox/can-use-paradox/build.sbt
+++ w/src/sbt-test/paradox/can-use-paradox/build.sbt
@@ -10,5 +10,10 @@ lazy val root = (project in file(".")).
       assert(index.exists, s"${index.getAbsolutePath} did not exist")
       val content = IO.readLines(index)
       assert(content.exists(_.contains("Paradox Testing")), s"Did not find expected content in:\n${content.mkString("\n")}")
+
+      for (path <- Seq("html/index.html", "theme/page.st")) {
+        val file = dest / "paradox" / path
+        assert(!file.exists, s"$file should not exist")
+      }
     }
   )

Here's a listing of the files generated by makeSite showing the intermediate files inside the paradox directory:

[info] .../can-use-paradox/target/site/docs
[info] .../can-use-paradox/target/site/docs/css
[info] .../can-use-paradox/target/site/docs/css/fonts
[info] .../can-use-paradox/target/site/docs/css/fonts/icons.eot
[info] .../can-use-paradox/target/site/docs/css/fonts/icons.svg
[info] .../can-use-paradox/target/site/docs/css/fonts/icons.ttf
[info] .../can-use-paradox/target/site/docs/css/fonts/icons.woff
[info] .../can-use-paradox/target/site/docs/css/page.css
[info] .../can-use-paradox/target/site/docs/index.html
[info] .../can-use-paradox/target/site/docs/js
[info] .../can-use-paradox/target/site/docs/js/magellan.js
[info] .../can-use-paradox/target/site/docs/js/page.js
[info] .../can-use-paradox/target/site/docs/lib
[info] .../can-use-paradox/target/site/docs/lib/foundation
[info] .../can-use-paradox/target/site/docs/lib/foundation/dist
[info] .../can-use-paradox/target/site/docs/lib/foundation/dist/foundation.min.css
[info] .../can-use-paradox/target/site/docs/lib/foundation/dist/foundation.min.js
[info] .../can-use-paradox/target/site/docs/lib/jquery
[info] .../can-use-paradox/target/site/docs/lib/jquery/jquery.min.js
[info] .../can-use-paradox/target/site/docs/lib/normalize.css
[info] .../can-use-paradox/target/site/docs/lib/normalize.css/normalize.css
[info] .../can-use-paradox/target/site/docs/lib/prettify
[info] .../can-use-paradox/target/site/docs/lib/prettify/lang-scala.js
[info] .../can-use-paradox/target/site/docs/lib/prettify/prettify.css
[info] .../can-use-paradox/target/site/docs/lib/prettify/prettify.js
[info] .../can-use-paradox/target/site/docs/paradox
[info] .../can-use-paradox/target/site/docs/paradox/html
[info] .../can-use-paradox/target/site/docs/paradox/html/index.html
[info] .../can-use-paradox/target/site/docs/paradox/theme
[info] .../can-use-paradox/target/site/docs/paradox/theme/css
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/fonts
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/fonts/icons.eot
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/fonts/icons.svg
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/fonts/icons.ttf
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/fonts/icons.woff
[info] .../can-use-paradox/target/site/docs/paradox/theme/css/page.css
[info] .../can-use-paradox/target/site/docs/paradox/theme/js
[info] .../can-use-paradox/target/site/docs/paradox/theme/js/magellan.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/js/page.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/foundation
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/foundation/dist
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/foundation/dist/foundation.min.css
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/foundation/dist/foundation.min.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/jquery
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/jquery/jquery.min.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/normalize.css
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/normalize.css/normalize.css
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/prettify
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/prettify/lang-scala.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/prettify/prettify.css
[info] .../can-use-paradox/target/site/docs/paradox/theme/lib/prettify/prettify.js
[info] .../can-use-paradox/target/site/docs/paradox/theme/menu.st
[info] .../can-use-paradox/target/site/docs/paradox/theme/navigation.st
[info] .../can-use-paradox/target/site/docs/paradox/theme/page.st
[info] .../can-use-paradox/target/site/docs/paradox/theme/title.st
@jonas jonas mentioned this issue Nov 16, 2016
Merged
@jonas jonas changed the title Generated Paradox site contains copy of raw theme and HTML files Generated Paradox site contains copy of intermediate theme and HTML files Nov 16, 2016
@metasim
Copy link
Member

metasim commented Nov 17, 2016

@jonas Anything you need from me on this one?

@jonas
Copy link
Member Author

jonas commented Nov 19, 2016

I'll try to get a fix ready in the start of next week. Let me know if you plan to release before.

jonas added a commit that referenced this issue Nov 19, 2016
@jonas
Use default target value for Paradox
079a63d 
The overridden value caused intermediate HTML and theme files to be
placed into the final output directory.

Fixes #80
@jonas jonas mentioned this issue Nov 19, 2016
Merged
@jonas jonas added the bug label Nov 19, 2016
@metasim
Copy link
Member

metasim commented Nov 20, 2016

No release plans.... I'm at your service :-)

@jonas
Copy link
Member Author

jonas commented Nov 20, 2016

OK, well I found a fix for my use case.

@jonas jonas added this to the 1.2.0 milestone Dec 15, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@jonas @metasim