Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.7] updateSbtClassifiers fails if some sources are not available #5374

Closed
OlegYch opened this issue Jan 15, 2020 · 14 comments
Closed

[1.3.7] updateSbtClassifiers fails if some sources are not available #5374

OlegYch opened this issue Jan 15, 2020 · 14 comments

Comments

@OlegYch
Copy link
Contributor

OlegYch commented Jan 15, 2020

steps

sbt version: 1.3.7
add

addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.8.0")

to project/plugins.sbt
run updateSbtClassifiers or try to import project in intellij

problem

[error] (updateSbtClassifiers) lmcoursier.internal.shaded.coursier.error.FetchError$DownloadingArtifacts: Error fetching artifacts:
[error] https://repo1.maven.org/maven2/org/webjars/npm/4.2.0/npm-4.2.0-sources.jar: not found: https://repo1.maven.org/maven2/org/webjars/npm/4.2.0/npm-4.2.0-sources.jar

expectation

update(Sbt)classifiers should continue if any source/doc downloads are not available

@OlegYch OlegYch added the Bug label Jan 15, 2020
@OlegYch
Copy link
Contributor Author

OlegYch commented Jan 15, 2020

sbt 1.3.6 works correctly

@OlegYch
Copy link
Contributor Author

OlegYch commented Jan 15, 2020

hm, now i can't reproduce this...

@eed3si9n
Copy link
Member

There's a flag in UpdateConfiguration called missingOk - https://github.com/sbt/librarymanagement/blob/v1.3.1/core/src/main/contraband-scala/sbt/librarymanagement/UpdateConfiguration.scala
I wonder if that's not being respected.

@OlegYch
Copy link
Contributor Author

OlegYch commented Jan 31, 2020

yeah lmcoursier.CoursierDependencyResolution#update ignores updateConfiguration

@mikail-khan
Copy link

Still broken even with the release of 1.3.8

@eed3si9n
Copy link
Member

eed3si9n commented Feb 4, 2020

@OlegYch Could you open an issue on coursier/coursier?

@OlegYch
Copy link
Contributor Author

OlegYch commented Feb 4, 2020

@eed3si9n opened coursier/coursier#1541

@eed3si9n
Copy link
Member

I am going to close this since I realized there's #4707

@He-Pin
Copy link

He-Pin commented Mar 28, 2020

[error] (akka-multi-node-testkit / updateSbtClassifiers) lmcoursier.internal.shaded.coursier.error.FetchError$DownloadingArtifacts: Error fetching artifacts:
[error] https://repo1.maven.org/maven2/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava-sources.jar: not found: https://repo1.maven.org/maven2/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava-sources.jar
[error] (updateSbtClassifiers) lmcoursier.internal.shaded.coursier.error.FetchError$DownloadingArtifacts: Error fetching artifacts:
[error] https://repo1.maven.org/maven2/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava-sources.jar: not found: https://repo1.maven.org/maven2/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava-sources.jar
[error] Total time: 19 s, completed 2020年3月29日 上午6:14:38

eed3si9n added a commit to eed3si9n/sbt-coursier that referenced this issue May 6, 2020
This is a continuation of coursier#212 and coursier#223
Ref coursier/coursier#1541
Ref sbt/sbt#4707
Ref sbt/sbt#5374
Ref sbt/sbt#5501

coursier#212 fixed the resolve, but did not handle missing sources during fetch. This attempts to fix that.
@jeffrey-aguilera
Copy link

Returned in 1.3.12...

@zhaihao
Copy link

zhaihao commented Jul 5, 2020

Returned in 1.3.13

@NicolasRouquette
Copy link

I downgraded to 1.3.11, which seems OK; 1.3.12 and 1.3.13 didn't work for me.

@JayZYan
Copy link

JayZYan commented Aug 8, 2020

tried 1.3.13, 1.3.12, 1.3.11, all not working for me...Downgrade to 1.3.6, which worked for me...

@nmatkheev
Copy link

Had the same thing, found two equivalent tricks:

  • disabling local maven repo in ~/.sbt/repositories
  • manual deletion of folder from .m2, where artifact mentioned in error message is stored

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants