Automatically run GC/finalization after each task execution. #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1223. * Add a new key to disable forcing the garbage collector to run after each task-executioin * Add a new flag to disable forcing the garbage collector to run after each task-exeuction * Add a hook into EvalauteTask to run System.gc/System.runFinalization after each task execution Review by @eed3si9n
| @@ -198,6 +211,9 @@ object EvaluateTask | |||
| val maker: State => Keys.TaskProgress = getSetting(Keys.executeProgress, const(new Keys.TaskProgress(defaultProgress)), extracted, structure) | |||
| maker(state).progress | |||
| } | |||
| // TODO - Should this pull from Global or from the project itself? | |||
| private[sbt] def forcegc(extracted: Extracted, structure: BuildStructure): Boolean = | |||
| getSetting(Keys.forcegc in Global, EvaluateTaskConfig.defaultForceGarbageCollection, extracted, structure) | |||
There was a problem hiding this comment.
Can it be scoped to the root task so it could be overridden at the task level? Not sure if that's useful.
There was a problem hiding this comment.
No. There can be multiple roots as of sbt 0.13.2 and you're not guaranteed to have a key relating to the task you run.
Also, I don't think it's particularly useful, but a good suggestion :)
|
LGTM |
eed3si9n
added a commit
that referenced
this pull request
Apr 22, 2014
Automatically run GC/finalization after each task execution.
| // Force finalizers to run. | ||
| System.runFinalization() | ||
| // Force actually cleaning the weak hash maps. | ||
| System.gc() |
There was a problem hiding this comment.
Just FYI: All of these are advisory and are no-ops on some JVMs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223.
after each task-executioin
after each task-exeuction
after each task execution
Review by @eed3si9n