Do not emit in the pom dependencies that are only sources or docs #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pom generation code tries its best to map Ivy's configurations to Maven scopes; however, sources and javadoc artifacts cannot be properly mapped and they currently are emitted as dependencies in the default scope (compile). That may lead to the source/doc jars being erroneously processed like regular jars by automated tools. Arguably, the source/docs jars should not be included in the pom file as dependencies at all. This commit filters out the dependencies that only appear in the sources and/or javadoc Ivy configurations, thereby preventing them from appearing in the final pom file.
|
LGTM |
|
Can you add notes? |
jsuereth
added a commit
that referenced
this pull request
May 27, 2015
Do not emit in the pom dependencies that are only sources or docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pom generation code tries its best to map Ivy's configurations
to Maven scopes; however, sources and javadoc artifacts cannot be
properly mapped and they currently are emitted as dependencies in
the default scope (compile). That may lead to the source/doc jars
being erroneously processed like regular jars by automated tools.
Arguably, the source/docs jars should not be included in the pom
file as dependencies at all. This commit filters out the
dependencies that only appear in the sources and/or javadoc Ivy
configurations, thereby preventing them from appearing in the
final pom file.
This pull request should fix #2001. Review by @eed3si9n and @jsuereth.