-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward port "Handle source, docs artifacts correctly for Ivy [1.0.x]" + update modules #2478
Conversation
…ks in conjunction with ArtifactTypeFilter
…w conflicts with sbt.Keys.. Thanks Scala
Looks like you've replicated quite a bit of work already in #2475, which is supposed sbt/sbt's counterpart of sbt/librarymanagement#25 (the breaking changes in Though, you should be aware that it's also necessary to set a default filter for Would it be possible to rebase these changes on top of that PR so that we don't get any overlap? |
@dansanduleac You're right. Maybe that it would be better to first merge #2475 and then rebase this one. |
7e1d31b
to
27d1d62
Compare
27d1d62
to
20d0c41
Compare
@Duhemm Thanks for rebasing. I see what's going on - all these subprojects are causing dependency hell.
I suspect your changes fall into step (2) above. |
https://travis-ci.org/sbt/sbt/jobs/111582958
A bunch of failures here too - https://travis-ci.org/sbt/sbt/jobs/111583017 |
It has changed and will be re-enabled by changes that have not yet been forward-ported from sbt 0.13.
d06e34e
to
5e16bba
Compare
Forward port "Handle source, docs artifacts correctly for Ivy [1.0.x]" + update modules
Merged |
I believe this was accidentally not forward-ported from the 0.14 branch to the 1.0.x branch. Notice the change was present in sbt#1016: https://github.com/sbt/sbt/pull/1016/files#diff-6373e7f7122325e753b75fe1cc76ff5fL576 and missing in sbt#2478: https://github.com/sbt/sbt/pull/2478/files#diff-6373e7f7122325e753b75fe1cc76ff5fR680
This PR currently refers to a locally published version of
incrementalcompiler
, which includes both sbt/zinc#70 and sbt/zinc#71.I'm thinking that maybe we should merge this PR in priority and then rebase all the forward port that were waiting for a release of
incrementalcompiler
orlibrarymanagement
.Note that this is not only adapting to changes. Because of the changes to the API of the incremental compiler I've had to make some other changes:
compileOptions
that produces axsbti.compile.CompileOptions
,sourceTypes
anddocTypes
that specify which artifacts must be considered source or doc artifacts.