(Do not merge) Fixes sbt/sbt#2264. Use explicit artifacts if any, fallback to hardcoded #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though it's not really used, updateClassifiers constructs dependency graph based on the result from update. The direct cause of sbt#2264 came from the fact that the `allModules` returned from ConfigurationReport did not include dependency configurations. For example it returned "compile" instead of "compile->runtime". I've identified that in sbt#2264 and was fixed by @Duhemm in sbt/sbt@f49fb33. Martin identified that the fix still does not address the fact that updateClassifier hardcodes the classifiers to be tried. This commit adds the fallback behavior so for Ivy-published modules it will use the explicit list of artifacts, and for others it will fallback to the hardcoded list of classifiers.
|
Can one of the admins verify this patch? |
|
This change is in direct conflict with the change added in #2478. |
|
I'm going to close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port for #2297. This won't compile until we have a new release of sbt/librarymanagement that includes both sbt/librarymanagement#9 and sbt/librarymanagement#13.