New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scalaInstanceTopLoader to compileBase settings #6480
Conversation
43124be
to
aeb5fd9
Compare
I haven't branched out develop to 1.5.x yet. Is this more of a 1.6.0-M1 feature or can this be "backported" to 1.5.x without going through the RC cycle? |
It is not forward compatible because I changed the scope of I can backport a lighter version, that just makes |
Maybe we can merge #6481 and put this one on hold for now. |
Backport #6480: Expose makeScalaInstance publicly
@eed3si9n This one should be ready to merge. |
Move
scalaInstanceTopLoader
anduseScalaReplJLine
tocompileBase
:They are/should only be used in the
JvmPlugin
to create thescalaInstance
.Move
jansiExclusionLoader
(for Scala 2.10 only) to thescalaInstanceTopLoader
implementationRemove the
ClassLoaderCache
hack for dotty:It is not needed anymore, since dotty uses sbt 1.5
Make
Defaults.makeScalaInstance
public:ScalaInstance
and thescalaInstance
task are public. But, to create a customscalaInstance
we need theextendedClassLoaderCache
which is package private. That's why I thinkmakeScalaInstance
should be public.This will allow us to properly bootstrap the Scala compiler in the dotty repository. See scala/scala3#12259.