[1.6.x] Throw when test framework cannot be loaded due to MatchError or NoClassDefFoundError #6806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssDefFoundError Problem ------- In some situations like Dotty Community Build, sbt version is mechanically upgraded on an old commit without humans checking the log. For reasons we're not completely sure (likely change in ClassLoader structure) sbt 1.6.x started to fail to load test frameworks during tests, but since the failure of the test framework loading doesn't fail the task, this silently succeeded the builds. Solution -------- On MatchError and NoClassDefFound Error, rethrow the exception. Note that ClassNotFoundException is considered ok since we have predefined test frameworks listed in sbt, which often are not included in the users' classpath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6805
Ref scala/scala3#14391
Ref #6480
Problem
In some situations like Dotty Community Build, sbt version is
mechanically upgraded on an old commit without humans checking the log.
For reasons we're not completely sure (likely change in ClassLoader
structure) sbt 1.6.x started to fail to load test frameworks during
tests, but since the failure of the test framework loading doesn't fail
the task, this silently succeeded the builds.
Solution
On MatchError and NoClassDefFound Error, rethrow the exception.
Note that ClassNotFoundException is considered ok since we have
predefined test frameworks listed in sbt, which often are not included
in the users' classpath.