This repository has been archived by the owner on Jun 10, 2020. It is now read-only.
Define OptJsonWriter & put it on AttributeKey #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply
import OptJsonWriter.OptOut._
And you'll get the implicit lift, but not the implicit fallback.
You get an ambiguous compile error like this:
[error] /d/sbt-util/internal/util-collection/src/main/scala/sbt/util/OptJsonWriter.scala:28: ambiguous implicit values:
[error] both method conflictingFallback1 in trait OptOut0 of type [A]=> sbt.util.NoJsonWriter[A]
[error] and method conflictingFallback2 in trait OptOut0 of type [A]=> sbt.util.NoJsonWriter[A]
[error] match expected type sbt.util.OptJsonWriter[Foo]
[error] val x = implicitly[OptJsonWriter[Foo]]
[error] ^
eed3si9n
reviewed
Mar 21, 2017
|
|
||
| trait OptOut0 { | ||
| implicit def conflictingFallback1[A]: NoJsonWriter[A] = NoJsonWriter() | ||
| implicit def conflictingFallback2[A]: NoJsonWriter[A] = NoJsonWriter() |
eed3si9n
suggested changes
Mar 21, 2017
| implicit def conflictingFallback1[A]: NoJsonWriter[A] = NoJsonWriter() | ||
| implicit def conflictingFallback2[A]: NoJsonWriter[A] = NoJsonWriter() | ||
| } | ||
| object OptOut extends OptOut0 { |
There was a problem hiding this comment.
Double "opt" is kind of confusing, so can we rename this to StrictMode?
eed3si9n
approved these changes
Mar 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.