Demote some warnings to echos to avoid failing with -Xfatal-warnings

sbt · Aug 11, 2020 · 105fcaa · 105fcaa
1 parent e085744
commit 105fcaa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/internal/compiler-bridge/src/main/scala/xsbt/Dependency.scala b/internal/compiler-bridge/src/main/scala/xsbt/Dependency.scala
@@ -95,7 +95,7 @@ final class Dependency(val global: CallbackGlobal) extends LocateClassFile with
           case Some(classOrModuleDef) =>
             memberRef(ClassDependency(classOrModuleDef, dep))
           case None =>
-            reporter.warning(unit.position(0), Feedback.OrphanTopLevelImports)
+            reporter.echo(unit.position(0), Feedback.OrphanTopLevelImports) // package-info.java & empty scala files
             orphanImportsReported = true
         }
       }

diff --git a/internal/compiler-bridge/src/main/scala/xsbt/ExtractAPI.scala b/internal/compiler-bridge/src/main/scala/xsbt/ExtractAPI.scala
@@ -598,6 +598,9 @@ class ExtractAPI[GlobalType <: Global](
           "sbt-api: Unexpected nullary method type " + in + " in " + in.owner
         )
         Constants.emptyType
+      case MethodType(_, _) =>
+        reporter.echo(NoPosition, s"sbt-api: Unhandled method type $in in ${in.owner}")
+        Constants.emptyType
       case _ =>
         reporter.warning(NoPosition, "sbt-api: Unhandled type " + t.getClass + " : " + t)
         Constants.emptyType

diff --git a/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala b/internal/compiler-bridge/src/main/scala/xsbt/ExtractUsedNames.scala
@@ -118,7 +118,7 @@ class ExtractUsedNames[GlobalType <: CallbackGlobal](val global: GlobalType)
           }
 
         case None =>
-          reporter.warning(unit.position(0), Feedback.OrphanNames)
+          reporter.echo(unit.position(0), Feedback.OrphanNames)
       }
     }