Fix discarded non-Unit value warnings

sbt · Jun 7, 2018 · b283e61 · b283e61
1 parent 9add603
commit b283e61
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 2 deletions.
diff --git a/internal/compiler-bridge/src/main/scala_2.13/xsbt/ConsoleInterface.scala b/internal/compiler-bridge/src/main/scala_2.13/xsbt/ConsoleInterface.scala
@@ -51,8 +51,12 @@ class ConsoleInterface {
         } else
           super.createInterpreter(interpreterSettings)
 
-        for ((id, value) <- bindNames zip bindValues)
-          intp.beQuietDuring(intp.bind(id, value.asInstanceOf[AnyRef].getClass.getName, value))
+        for ((id, value) <- bindNames zip bindValues) {
+          intp.beQuietDuring {
+            intp.bind(id, value.asInstanceOf[AnyRef].getClass.getName, value)
+            ()
+          }
+        }
 
         if (!initialCommands.isEmpty)
           intp.interpret(initialCommands)
@@ -68,6 +72,7 @@ class ConsoleInterface {
     }
 
     loop.run(compilerSettings)
+    ()
   }
 }
 

diff --git a/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/FilteredReporter.scala b/internal/zinc-compile-core/src/main/scala/sbt/internal/inc/FilteredReporter.scala
@@ -88,6 +88,7 @@ class FilteredReporter(
       val transformedPos: Position = positionMapper(position)
       val problem = InterfaceUtil.problem(category, transformedPos, message, severity)
       allProblems += problem
+      ()
     }
   }
 }
diff --git a/...rnal/zinc-compile-core/src/test/scala/sbt/internal/inc/javac/JavacProcessLoggerSpec.scala b/...rnal/zinc-compile-core/src/test/scala/sbt/internal/inc/javac/JavacProcessLoggerSpec.scala
@@ -34,6 +34,7 @@ class JavaProcessLoggerSpec extends UnitSpec {
 
     errorLogger.messages shouldBe Map.empty
     reporter.problems.length shouldBe 2
+    ()
   }
 
   def logSeparateSemanticErrors(): Unit = {
@@ -56,6 +57,7 @@ class JavaProcessLoggerSpec extends UnitSpec {
 
     errorLogger.messages shouldBe Map.empty
     reporter.problems.length shouldBe 2
+    ()
   }
 
   def logUnparsableErrors(): Unit = {
@@ -71,5 +73,6 @@ class JavaProcessLoggerSpec extends UnitSpec {
       .messages(Level.Warn)(0)
       .contains("javadoc: error - invalid flag: -target") shouldBe true
     errorLogger.messages(Level.Warn)(1).contains("javadoc exited with exit code -1") shouldBe true
+    ()
   }
 }
diff --git a/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala b/internal/zinc-core/src/main/scala/sbt/internal/inc/APIDiff.scala
@@ -165,8 +165,10 @@ private[inc] class APIDiff {
       def build(x: Array[String], y: Array[String], builder: mutable.ArrayBuilder[Patch]): Unit = {
         if (x.isEmpty) {
           builder += Inserted(y.mkString)
+          ()
         } else if (y.isEmpty) {
           builder += Deleted(x.mkString)
+          ()
         } else if (x.length == 1 || y.length == 1) {
           needlemanWunsch(x, y, builder)
         } else {
@@ -251,6 +253,7 @@ private[inc] class APIDiff {
         }
       }
       builder ++= alignment
+      ()
     }
 
   }

diff --git a/zinc/src/test/scala/sbt/inc/BaseCompilerSpec.scala b/zinc/src/test/scala/sbt/inc/BaseCompilerSpec.scala
@@ -89,6 +89,7 @@ class BaseCompilerSpec extends BridgeProviderSpecification {
       val sourceFile = baseLocation.resolve(source)
       val text = Files.readAllLines(sourceFile).asScala.mkString("\n")
       Files.write(sourceFile, Seq(change(text)).asJava)
+      ()
     }
 
     def dependsOnJarFrom(other: ProjectSetup): ProjectSetup = {